Conversation
### Problem The `HitsList` SwiftUI view crashes with an index out of bounds error when search results update during rendering. **Root Cause:** Race condition between `ForEach` iteration and the `@Published` hits array being updated. `ForEach` captures the array count, but before rendering completes, `reload()` updates the array (potentially from a background thread). When SwiftUI accesses `hits[index]`, the array may have shrunk, causing a crash. ### Solution 1. **Thread Safety**: Wrap `reload()` updates in `DispatchQueue.main.async` to ensure `@Published` changes happen on main thread 2. **Bounds Checking**: Check array bounds before access, passing `nil` to the row closure if index is out of bounds
afrencalg
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
HitsListSwiftUI view crashes with an index out of bounds error when search results update during rendering.Root Cause: Race condition between
ForEachiteration and the@Publishedhits array being updated.ForEachcaptures the array count, but before rendering completes,reload()updates the array (potentially from a background thread). When SwiftUI accesseshits[index], the array may have shrunk, causing a crash.Solution
reload()updates inDispatchQueue.main.asyncto ensure@Publishedchanges happen on main threadnilto the row closure if index is out of bounds